-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document option for daemon config validation #3108
Conversation
I moved this temporarily to "draft", pending moby/moby#42393 to be merged |
99b8ec3
to
cf1442d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3108 +/- ##
=======================================
Coverage 56.96% 56.96%
=======================================
Files 299 299
Lines 18733 18733
=======================================
Hits 10672 10672
Misses 7193 7193
Partials 868 868 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completion LGTM, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
moved out of draft as moby PR was merged, but it needs a minor update (I'll leave a comment) |
1 similar comment
moved out of draft as moby PR was merged, but it needs a minor update (I'll leave a comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment 🤗
|
||
```console | ||
$ dockerd --validate --config-file=/tmp/valid-config.json | ||
Config OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changed to
Config OK | |
configuration OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also mention that the exit status will be 0 (success) and non-zero (failure)? as that's the "actual" check (message that's printed is informational)?
c09cb25
to
64b2e95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
We are adding a
--validate
option to dockerd to check if the config file is valid without starting the daemon.Related to moby/moby#42393
- What I did
Added
--validate
option to the docker daemon options documentation.- Description for the changelog
Update documentation and shell completion for the daemon validation option.